Fix hover on IE #6466
Merged
Fix hover on IE #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
💃 That's clearer usage anyway - x and y for a bounding box are ambiguous.
That said, I really don't want us spending more time on IE. I'd prefer we explicitly drop support for it (maybe the same way we did in Dash: remove 'es5' from the webpack config target and add "browserslist": ["last 7 years and not dead"] to package.json (which webpack picks up) so that we don't feel any need to test in IE ever again.
|
The fact that this bug has been present since v2.5 is a good indication that IE doesn't matter to our users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in [v2.5.0](https://github.com/plotly/plotly.js/releases/tag/v2.5.0 by 388986b777. cc: #5916.
It appears the
getBoundingClientRectmethod on IE does not returnxandy!Instead one should use
leftandtop.@plotly/plotly_js