Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posibility of a 2.3.2 release with less strict d3-interpolate version dependency #5886

Closed
evansrobert opened this issue Aug 11, 2021 · 2 comments

Comments

@evansrobert
Copy link

Hi, @archmoj,

Issue Description

I noticed that a vulnerability is introduced in plotly.js@2.3.1:
Vulnerability SNYK-JS-D3COLOR-1076592 affects package d3-color (versions:<3.0.0): https://snyk.io/vuln/SNYK-JS-D3COLOR-1076592
The above vulnerable package is referenced by plotly.js@2.3.1 via:
plotly.js@2.3.1 ➔ d3-interpolate@1.4.0 ➔ d3-color@1.4.1

Since plotly.js@2.3.1 (10,096 downloads per week) is referenced by 38 downstream projects (e.g., jupyterlab-plotly 5.1.0 (latest version), @interpretml/interpret-inline 0.2.6 (latest version), @deephaven/code-studio 0.2.1 (latest version), @intermix-dashboard/victory 0.7.0 (latest version), @deephaven/chart 0.2.1 (latest version)), the vulnerability SNYK-JS-D3COLOR-1076592 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1)jupyterlab-plotly@5.1.0 ➔ plotly.js@2.3.1 ➔ d3-interpolate@1.4.0 ➔ d3-color@1.4.1
(2)@interpretml/interpret-inline@0.2.6 ➔ plotly.js@2.3.1 ➔ d3-interpolate@1.4.0 ➔ d3-color@1.4.1
......

If plotly.js@2.3.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from plotly.js@2.3.1 ?

Fixing suggestions

In plotly.js@2.3.2, maybe you can kindly try to perform the following upgrade :
d3-interpolate ^1.4.0 ➔ ^3.0.0;

Note:
d3-interpolate@3.0.0(>=3.0.0) directly depends on d3-color@3.0.1 which has fixed the vulnerability SNYK-JS-D3COLOR-1076592.
Of course, you are welcome to share other ways to resolve the issue.

Thank you for your attention to this issue.

Best regards,
^_^

@archmoj
Copy link
Contributor

archmoj commented Aug 11, 2021

Please note that there was no version change in the following packages between plotly.js v1.58.4 and plotly.js v2.3.1:

└─┬ d3-interpolate@1.4.0
  └── d3-color@1.4.1 

Also noting that d3-interpolat@v2 dropped support for IE, upgrading may not be a feasible choice at this point.
What about fixing the issue in d3-interpolate v1?

@archmoj
Copy link
Contributor

archmoj commented Feb 1, 2023

Addressed in #6463.

@archmoj archmoj closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants