Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid autoscale error with false autorange #5336

Merged
merged 4 commits into from Dec 11, 2020
Merged

Avoid autoscale error with false autorange #5336

merged 4 commits into from Dec 11, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 10, 2020

Fixes #5290.

@plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Looks good, can we add a test for this?

@archmoj @alexcjohnson
Update test/jasmine/tests/axes_test.js
ddc1c8a 
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
alexcjohnson
alexcjohnson approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! 💃 after my minor comments.

@archmoj @alexcjohnson
Update test/jasmine/tests/axes_test.js
5dee4fc 
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
@archmoj archmoj merged commit 82da615 into master Dec 11, 2020
@archmoj archmoj deleted the fix5290-autorange-false-error branch December 11, 2020 14:44
@archmoj archmoj mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug type: regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoscale error with false axis.autorange
2 participants
@archmoj @alexcjohnson