Adjust minfinalheight in automargin routine to allow narrow subplots e.g. gauge #5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce minfinalheight to 16 - revert jasmine tests to what we had before commit 565f942
alexcjohnson
reviewed
Dec 4, 2020
| @@ -1866,8 +1866,8 @@ function initMargins(fullLayout) { | |||
| if(!fullLayout._pushmarginIds) fullLayout._pushmarginIds = {}; | |||
| } | |||
|
|
|||
| var minFinalWidth = 64; // could possibly be exposed as layout.margin.minfinalwidth | |||
| var minFinalHeight = 64; // could possibly be exposed as layout.margin.minfinalheight | |||
There was a problem hiding this comment.
I think we should define two values for each dimension here (so repeat this for width as well):
// non-negotiable - this is the smallest height we will allow users to specify via explicit margins
var MIN_SPECIFIED_HEIGHT = 2;
// could be exposed as an option - the smallest we will allow automargin to shrink a larger plot
var MIN_REDUCED_HEIGHT = 64;Then down below we can combine these two:
var minFinalHeight = Lib.constrain(
height - margin.t - margin.b,
MIN_SPECIFIED_HEIGHT,
MIN_REDUCED_HEIGHT
);The goal is:
- if you specify a plot height larger than
MIN_REDUCED_HEIGHT, automargin is allowed to increase the top and bottom margins to reduce the plot height as low asMIN_REDUCED_HEIGHT. - if you specify a plot area smaller than
MIN_REDUCED_HEIGHTbut larger thanMIN_SPECIFIED_HEIGHT, automargin will make no changes. - if you specify a plot height smaller than
MIN_SPECIFIED_HEIGHT, automargin should reduce the margins symmetrically to increase the plot height back toMIN_SPECIFIED_HEIGHT
archmoj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5314.
@plotly/plotly_js