Implement strict autotypenumbers

[archmoj]

Fixes #5250 and,
Resolves #5195 by introducing two new attributes at layout and axis levels.

TODO:

• add tests

@plotly/plotly_js

[alexcjohnson]

I think it would be better to leave else return '-', for empty arrays and arrays with only null entries, and instead include convertNumeric in the category(array) call, ie replace:

else if(Lib.cleanNumber(ai) !== BADNUM) curvenums++;

with something like:

else if(convertNumeric ? Lib.cleanNumber(ai) !== BADNUM : typeof ai === 'number') curvenums++;

[archmoj]

Good call. Done in b73d395.

[nicolaskruchten]

OK so @alexcjohnson and I chatted about this and the attribute name should be autotypenumbers and it should be an enum with values "accept strings" or "strict", default value is "accept strings".

[alexcjohnson]

@archmoj pointed out just now that while we're at it here we could stop treating the number 2000 as a date for autotype purposes. Basically: as far as autotype is considered, in strict mode dates must be strings, numbers must be numbers, and categories must not be numbers.

I like this idea, and I think 'strict' is still a good value, but I think then we should change 'accept strings' to 'convert types' or 'cast types'.

[nicolaskruchten]

is it just the number 2000 or something like "integers below 3000" ?

[alexcjohnson]

I'd have to check exactly, but I believe it's at least all 4-digit integers, possibly also 2-digit integers.

[archmoj]

I'd have to check exactly, but I believe it's at least all 4-digit integers, possibly also 2-digit integers.

Also 2-digit integers: Demo.

[archmoj]

@nicolaskruchten @alexcjohnson
This PR is now ready to review.
Thank you!

[alexcjohnson]

💃 💯