Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test AppVeyor Windows executable on a Windows machine #70

Closed
etpinard opened this issue Apr 13, 2018 · 5 comments
Closed

Test AppVeyor Windows executable on a Windows machine #70

etpinard opened this issue Apr 13, 2018 · 5 comments

Comments

@etpinard
Copy link
Contributor

PR #63 added a build step for Windows on AppVeyor.

Unfortunately, no one has had the time to test it out yet.

@n-riesco
Copy link
Contributor

For the record (it may be a red herring though): when I ran the windows executable with --verbose, the dev console had an error message Uncaught SyntaxError: invalid unicode escape sequence.

@JamesCropcho
Copy link
Contributor

@n-riesco If you ran it on Windows: I wager it's important and useful. If you ran it not on Windows, I'd wager it's a red herring.

@n-riesco
Copy link
Contributor

n-riesco commented Apr 14, 2018

@JamesCropcho To be clear: I ran the windows executable on a windows machine. 😺

@JamesCropcho
Copy link
Contributor

@n-riesco Yeah, I was pretty sure you were running it in a Windows environment, but I wanted to one hundred percent sure. Also, the specific error message you described sounds like the flavor associated with executable-environment mismatch.

Interesting, I do not get output matching yours:

Microsoft Windows [Version 10.0.16299.371]
(c) 2017 Microsoft Corporation. All rights reserved.                                                                                                                                                                                            C:\Users\James>"C:\Users\James\AppData\Local\Programs\image-exporter\Plotly Graph Exporter.exe" --verbose
C:\Users\James>
(node:204) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: no valid input given
(node:204) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.                                                                                                                                                              

C:\Users\James>                                                                                                          

(The UnhandledPromiseRejectionWarning was showing up previously, too, when zero arguments were attached, so one may disregard that.)

I wonder if it's because we have different versions of Windows.

And/or, it may matter that I am still using yesterday's executable, in case something changed since then.

@etpinard
Copy link
Contributor Author

etpinard commented May 3, 2018

Fixed by 63e5434

(at least, on @dy's Windows 7 laptop)

@etpinard etpinard closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants