Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mySQL update to v8 #264

Closed
FraglyG opened this issue Mar 15, 2023 · 3 comments
Closed

mySQL update to v8 #264

FraglyG opened this issue Mar 15, 2023 · 3 comments

Comments

@FraglyG
Copy link

FraglyG commented Mar 15, 2023

I love quickdb.js, though it seems I can't use it on hosting services like railway because the underlying mysql isn't up to date and thus doesn't support mysql v8

an update to mysql v8 would be super cool

@Zelak312
Copy link
Collaborator

Zelak312 commented Mar 15, 2023

Thank your for this. I will be looking into it. I will probably be changing the library quick.db is using currently

@Zelak312
Copy link
Collaborator

I looked into it and you are right. v8 of mysql is not supported by the module we use which is promise-sql. promise-sql uses mysqljs/mysql which doesn't support it yet. you can see here a pull request that was open about it for a while now but doesn't seem to have progressed much mysqljs/mysql#2233

I seen that people are making a mysql2 library which seems as popular as the mysql one. I didn't see any problems on their github mentionning incompatibility with v8. I will be testing if this library works and if it does, I will be changing quick.db to use this one instead (should be done today or this weenkend)

Zelak312 added a commit that referenced this issue Mar 20, 2023
@Zelak312
Copy link
Collaborator

This should be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants