Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolutions generated in wrong place in PlayService project #12266

Open
PromanSEW opened this issue Dec 12, 2023 · 6 comments
Open

Evolutions generated in wrong place in PlayService project #12266

PromanSEW opened this issue Dec 12, 2023 · 6 comments

Comments

@PromanSEW
Copy link
Contributor

PromanSEW commented Dec 12, 2023

When you use PlayService, evolutions are still generating in conf folder instead of src/main/resources
Plugin should honor project layout

EDIT: Seems like this issue related to play-jdbc-evolutions in main repo, please move

@mkurz mkurz transferred this issue from playframework/play-ebean Dec 12, 2023
@mkurz
Copy link
Member

mkurz commented Dec 12, 2023

This is known, there are other places where we still hardcode the conf folder, see

@PromanSEW
Copy link
Contributor Author

Fix: add to build.sbt in settings section

PlayKeys.devSettings += ("play.evolutions.path", "./src/main/resources/evolutions")

@mkurz
Copy link
Member

mkurz commented Dec 12, 2023

Fix: add to build.sbt in settings section

PlayKeys.devSettings += ("play.evolutions.path", "./src/main/resources/evolutions")

Be aware this is just for dev mode.

@PromanSEW
Copy link
Contributor Author

@mkurz I know. This is for updating script while development

@PromanSEW
Copy link
Contributor Author

PromanSEW commented Dec 12, 2023

@mkurz seems like this issue should have been "fixed" by #11917, but in fact directoryName method still returns hardcoded conf folder for default config value

@mkurz
Copy link
Member

mkurz commented Dec 12, 2023

@PromanSEW #11917 was not about fixing the hardcoded conf folder, but about to allow the evolution folder to be placed outside the application's root folder. I just kept the hardcoded conf folder for now, so by default it's the same "wrong" behaviour. The intention of #11917 was not to fix the hardcoded conf folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants