Drop support for sbt < 1.4 in code

[mkurz]

In PRs like #10648 we introduced lots of reflection code to handle sbt 0.13 - 1.3 and 1.4+
I think after 2.9 we can refactor lots of this code, e.g things like:

playframework/dev-mode/sbt-plugin/src/main/scala/play/sbt/run/PlayReload.scala

Lines 158 to 187 in 7c0abcb

	val name = vf.getClass.getSimpleName
	name == "BasicVirtualFileRef" || name == "MappedVirtualFile"
	}
	}
	def sourceMap(analysis: Analysis): Map[String, Source] = {
	analysis.relations.classes.reverseMap.flatMap {
	case (name, files) =>
	files.headOption match { // This is typically a set containing a single file, so we can use head here.
	case None => Map.empty[String, Source]
	case JFile(file) => // sbt < 1.4
	Map(name -> Source(file, MaybeGeneratedSource.unapply(file).flatMap(_.source)))
	case VirtualFile(vf) => // sbt 1.4+ virtual file, see #10486
	val names = vf.getClass.getMethod("names").invoke(vf).asInstanceOf[Array[String]]
	val path =
	if (names.head.startsWith("${")) { // check for ${BASE} or similar (in case it changes)
	// It's an relative path, skip the first element (which usually is "${BASE}")
	Paths.get(names.drop(1).head, names.drop(2): _*)
	} else {
	// It's an absolute path, sbt uses them e.g. for subprojects located outside of the base project
	val id = vf.getClass.getMethod("id").invoke(vf).asInstanceOf[String]
	// In Windows the sbt virtual file id does not start with a slash, but absolute paths in Java URIs need that
	val extraSlash = if (id.startsWith("/")) "" else "/"
	val prefix = "file://" + extraSlash
	// The URI will be like file:///home/user/project/SomeClass.scala (Linux/Mac) or file:///C:/Users/user/project/SomeClass.scala (Windows)
	Paths.get(URI.create(s"$prefix$id"));
	}
	Map(name -> Source(path.toFile, MaybeGeneratedSource.unapply(path.toFile).flatMap(_.source)))

[Nezisi]

I think it would be better to make SBT 1.8 mandatory for Play 2.9.

SBT 1.8 fixed a lot of critical bugs, plus the improved Scala 3 support and the Scala XML bump.

I think it would reduce a lot of burden on maintenance for the Play 2.9 release long-term, too.

I'll have a look at your mentioned code and will try to get a PR together, with additional removal of deprecated SBT syntax.

If you could give any more pointers, I'd be glad - otherwise I'll try to give an update over the course of the week.

Thanks for all your efforts :)

[mkurz]

We don't need to change anything now, there is no pressure. Actually, I am planning to only officially support sbt 1.9.0+ for Play 2.9. We will mention that in the Release notes, so if people don't upgrade to 1.9.0 but report bugs, we tell them anything below sbt 1.9.0 is not supported so we don't fix any bugs related to that.

[Nezisi]

That sounds like a really good plan.

Sorry, I misunderstood the bug report, it sounded like you wanted to keep the pre SBT 1.9 support alive for 2.9 .

[mkurz]

it sounded like you wanted to keep the pre SBT 1.9 support alive for 2.9 .

It will be kept alive, and it will very likely work, but only bugs related to 1.9.0+ will be looked at and fixed, anything below we will just tell people to upgrade.