[2.8.x] Bump version of sharable workflows to v2
#11269
Conversation
| @@ -7,9 +7,6 @@ on: | |||
| branches: | |||
| - 2.8.x # Check 2.8.x branch after merge | |||
|
|
|||
| schedule: | |||
There was a problem hiding this comment.
I removed that for it does not mislead anyone
There was a problem hiding this comment.
OK, let's remove it. Actually I was hoping we could just copy the file to the main branch 1:1 every time we change something. However we can not copy 1:1, because we can not add ref: 2.8.x here because that would not be correct of course for pull requests and pushes. There will alway be a small difference, like we alway need to remove on push and on pull_requestfor the cron job (besides the ref: 2.8.x), see #11271
There was a problem hiding this comment.
You wrote my thoughts 😄 At first like you I wanted to have a 1:1 copy and to add comment like "DON'T WORK IN NON-DEFAULT BRANCH". But when I understood that in main branch we should remove on/pull_request section and add ref in every jobs then I decided remove it 😄
As continue of #11262