Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8.x] Switch to GitHub actions #11262

Merged
merged 18 commits into from May 5, 2022
Merged

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented May 1, 2022

Very similar to #11142, just also includes tests against Scala 2.12.15 and sbt 1.3.13 (for scripted tests), but these are only activated for cron jobs. Actually I also diffed the original .travis.yml from the main and the 2.8.x branch to make sure I don't forget anything, but besides the additional Scala and sbt versions there was nothing.

Also includes backports of

In travis each of this tasks in the alias was called in each own sbt command
- 2.8.x # Check 2.8.x branch after merge

schedule:
- cron: "0 3 * * *" # Nightly build (@daily)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/58798886/github-actions-schedule-operation-on-branch
Looks like we need something more smartly for cron task for 2.8.x branch 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I read this in the offical docs as well. We need to start the 2.8.x cron job from the default (main) branch 😢

Copy link
Member

@ihostage ihostage May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a duplicate of build workflow for 2.8.x? In main branch for schedule and in 2.8.x for PR's, right? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, this is the only solution, to have duplicated workflow files in both branches.
I was thinking about other solutions, like define a workflow in the main branch that uses the GitHub api to trigger the workflow from the 2.8.x branch with curl, but that is also not possible:

...your workflow must be in the default branch....

There is even this action from the marketplace, but with the same limitations with the rest api (of course, its just a wrapper).

Also the repository_dispatch event can only be used to trigger workflows from the default branch.

I also was looking into composite actions, but I can not see how they help here.

Anyway.
There is a discussion going on already:
https://github.community/t/scheduled-builds-of-non-default-branch/16306
However since there is no offical "bug" yet, I created one 😛 :
community/community#16107

So I think we have to use duplicate files now... Let's hope they implement this feature soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say 🤷‍♂️ We will have to play by these rules for now 😞

@mkurz mkurz merged commit a931af7 into playframework:2.8.x May 5, 2022
@mkurz mkurz deleted the github-actions-2.8.x branch May 5, 2022 22:41
@mkurz mkurz added this to the 2.8.16 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants