Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for checking URL with protocol='bundleresource' existence #11251

Closed
asaelitz opened this issue Apr 26, 2022 · 5 comments · Fixed by #11252
Closed

Adding support for checking URL with protocol='bundleresource' existence #11251

asaelitz opened this issue Apr 26, 2022 · 5 comments · Fixed by #11252
Milestone
2.8.16

Comments

@asaelitz
Copy link
Contributor

asaelitz commented Apr 26, 2022 •
edited

Hi.

Can you please add the merged PR: #11108 to the next release.

Thanks,
Asael
@mkurz mkurz added this to the 2.8.16 milestone Apr 26, 2022
@mkurz
Copy link
Member

mkurz commented Apr 26, 2022

@asaelitz Yes, we can.

@asaelitz
Copy link
Contributor Author

Thanks!

@asaelitz
Copy link
Contributor Author

For general knowledge, how do you decide which PR you taking for the next release?

@mkurz
Copy link
Member

mkurz commented Apr 26, 2022

If you mean the next 2.8.x release, we usually include bug fixes. We are also not reluctant to add (small) new features, as long as they don't break binary compatibility, however every code change could possibly break other behaviour, that's why new features usually should be merged in the the main (=dev) branch, not the 2.8.x one.

@PromanSEW
Copy link
Contributor

Fixed by #11252

@mkurz mkurz linked a pull request May 4, 2022 that will close this issue
[2.8.x] Adding support for checking URL with protocol='bundleresource' existence #11252
Merged
@ihostage ihostage changed the title Adding merged PR to next release Adding support for checking URL with protocol='bundleresource' existence May 6, 2022
@mkurz mkurz closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.16
Development

Successfully merging a pull request may close this issue.

[2.8.x] Adding support for checking URL with protocol='bundleresource' existence mkurz/playframework
3 participants
@mkurz @PromanSEW @asaelitz