Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives with arrow functions in no-hooks-from-ancestor-modules rule #275

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Nov 29, 2022

This bug was caused by #267 which was attempting to fix #246.

The previous fix updated the FunctionExpression check in one place but not the other.

CC: @platinumazure @bretjb

@bmish bmish added the bug label Nov 29, 2022
@coveralls
Copy link

coveralls commented Nov 29, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 8e687f5 on bmish:fix-arrow-no-hooks-from-ancestor-modules into 98572d5 on platinumazure:master.

@platinumazure platinumazure merged commit abcb81e into platinumazure:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-hooks-from-ancestor-modules does not catch when arrow function is used
3 participants