Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove npm upgrade step from CI #264

Merged
merged 1 commit into from Nov 14, 2022

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Nov 14, 2022

It looks like CI is currently failing because we upgrade npm during CI to a version no longer compatible with Node 12.

ERROR: npm v9.1.1 is known not to run on Node.js v12.22.12. You'll need to
upgrade to a newer Node.js version in order to use this version of npm. This
version of npm supports the following node versions: `^14.17.0 || ^1[6](https://github.com/platinumazure/eslint-plugin-qunit/actions/runs/3461679329/jobs/5779590138#step:5:7).13.0 ||
>=18.0.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)

I don't know why we need to upgrade npm. Most CI scripts do not need to upgrade npm.

Upgrade step originally added here: 432744a

@bmish bmish added the chore label Nov 14, 2022
@coveralls
Copy link

coveralls commented Nov 14, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling ac9d654 on bmish:remove-npm-upgrade into e12cfe9 on platinumazure:master.

Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@platinumazure platinumazure merged commit c27c2a2 into platinumazure:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants