Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested .editorconfig not supported #1

Closed
platinumazure opened this issue Jul 13, 2017 · 3 comments
Closed

Nested .editorconfig not supported #1

platinumazure opened this issue Jul 13, 2017 · 3 comments

Comments

@platinumazure
Copy link
Owner

This plugin could probably work with a single .editorconfig in the root directory of a project. However, nested .editorconfig files will not be picked up, and in fact the plugin's exported configuration will not even be executed more than once.

Unfortunately this is blocked by ESLint, since it is not designed to re-process configuration multiple times (usually for good reason, since performance could tank). We will need to reach out to ESLint to see if there is a way we could change this on an opt-in basis for specific plugins or configurations.

@platinumazure
Copy link
Owner Author

Tracking the upstream issue at eslint/eslint#8943.

@platinumazure
Copy link
Owner Author

Update: Since .editorconfig uses glob patterns and since ESLint supports glob-based configuration, our best bet may be to read .editorconfig files in CWD + descendant directories, and combine the glob patterns into a single configuration. Hoping to explore that in the next couple of weeks.

@platinumazure
Copy link
Owner Author

Apparently I solved this (or at least partially solved this) almost three years ago.

Wow.

I guess I'll close this for now. If anyone has trouble with nested .editorconfig files, please open a new issue and describe your use case in detail. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant