New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage reporting fixes #121

Merged

gaborbernat merged 1 commit into platformdirs:main from nedbat:main

Dec 28, 2022

Contributor

nedbat commented Dec 28, 2022

You need the [toml] extra to read .toml files before Python 3.11
When you moved settings from setup.cfg to pyproject.toml, you left behind some of your path mappings.

I also fixed a bug in coverage.py what should have raised an error for having a .toml file without the [toml] extra.


          this fixes the coverage reporting

0c26262

nedbat requested review from gaborbernat, ofek, Julian and RonnyPfannschmidt as code owners

December 28, 2022 01:06

nedbat mentioned this pull request

Combining coverage across platforms on coverage 7 nedbat/coveragepy#1516

Closed

gaborbernat approved these changes

View reviewed changes

gaborbernat approved these changes

View reviewed changes

gaborbernat merged commit 5d16771 into platformdirs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gaborbernat gaborbernat approved these changes

ofek Awaiting requested review from ofek ofek is a code owner

Julian Awaiting requested review from Julian Julian is a code owner

RonnyPfannschmidt Awaiting requested review from RonnyPfannschmidt RonnyPfannschmidt is a code owner