Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #114 #115

Merged
merged 1 commit into from Dec 28, 2022
Merged

Fix #114 #115

merged 1 commit into from Dec 28, 2022

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Dec 7, 2022

No description provided.

gaborbernat
gaborbernat requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry and a test please?

gaborbernat
gaborbernat reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no code change here now, can you fix the merge conflict?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Dec 7, 2022

ok

gaborbernat
gaborbernat reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only changes the tests, not the runtime code?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Dec 7, 2022

This only changes the tests, not the runtime code?

It's my fault of tiredness. Now it is fixed.

gaborbernat
gaborbernat reviewed Dec 7, 2022
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@Freed-Wu @gaborbernat
Fix #114
586d6ee 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 79e262e into platformdirs:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat requested changes

@ofek ofek Awaiting requested review from ofek ofek is a code owner

@Julian Julian Awaiting requested review from Julian Julian is a code owner

@RonnyPfannschmidt RonnyPfannschmidt Awaiting requested review from RonnyPfannschmidt RonnyPfannschmidt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Freed-Wu @gaborbernat