Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog does not contain unreleased changes from appdirs that were made before forking #11

Closed
Jackenmen opened this issue Jul 13, 2021 · 3 comments · Fixed by #12
Closed

Comments

@Jackenmen
Copy link
Contributor

Jackenmen commented Jul 13, 2021

In particular changelog does not contain breaking changes that were made in appdirs's master branch before forking, for example the change to user_config_dir and site_config_dir:
ActiveState/appdirs#63

There might be more but this is the one change that I know of that can definitely be breaking for existing applications.

@Jackenmen Jackenmen changed the title Changelog does not contain breaking changes that were made in appdirs's master branch before forking Changelog does not contain unreleased changes from appdirs that were made before forking Jul 13, 2021
@Jackenmen
Copy link
Contributor Author

Update: it appears that appdirs 1.4.4 changelog contains it but version 1.4.4 did not make that change which you can see here:
https://github.com/ActiveState/appdirs/blob/1.4.4/appdirs.py#L195

@Julian
Copy link
Member

Julian commented Jul 13, 2021

A PR would be very welcome if you can for this.

@Jackenmen
Copy link
Contributor Author

Other (IMO) noteworthy changes that I've found while looking through commit log:

  • added support for Python 3.8 and 3.9 (changelog only mentions 3.7)
  • dropped pywin32 dependency
  • added os.environ fallback for jython (not entirely sure whether appdirs 1.4.4 was affected as the logic for getting appdata seems to have changed since 1.4.4 as well and it might just be a bug that was only ever in master)

A PR would be very welcome if you can for this.

Well, I guess that now that I finished writing other stuff that could be added, I might as well PR, will do so in a moment 😄

Also since I'm already commenting...
CC: @gaborbernat as I know you released a new virtualenv version and I'm not entirely sure whether you were aware of the breaking change I mentioned in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants