Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for new features: Pagination and Additional Info #38

Open
bedroesb opened this issue May 6, 2019 · 2 comments
Open

Suggestions for new features: Pagination and Additional Info #38

bedroesb opened this issue May 6, 2019 · 2 comments

Comments

@bedroesb
Copy link

bedroesb commented May 6, 2019

  • Add pagination testing
  • list which attributes in a call are not from the Brapi specification (maybe not as an error but just so people can easily spot which additional attributes are added, so they are all intentionally)
@langeipk
Copy link
Collaborator

langeipk commented May 6, 2019

Pagination testing make sense. I suggest to test page sizes of 1, 10, 100 and max
regarding list no-BrAPI attributes, we decided to not display this explicitely. The argumentation is that BrAPI consortium should not restrict or even warn for additional attributes. They are anyway private is must be ignored from public.

@bedroesb
Copy link
Author

bedroesb commented May 6, 2019

I think testing the last page is also an important one.
I was not really thinking of warnings, but just an ability to check them. I thought it would be useful to see typos in existing attributes. For example plantNumber vs plantnumber.

@BrapiCoordinatorSelby BrapiCoordinatorSelby changed the title Suggestions for new features Suggestions for new features: Pagination and Additional Info Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants