Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test errors against pull requests #62

Closed
Samweli opened this issue Nov 4, 2022 · 5 comments
Closed

CI test errors against pull requests #62

Samweli opened this issue Nov 4, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Samweli
Copy link
Collaborator

Samweli commented Nov 4, 2022

Current CI workflow raises errors when it runs agains pull requests made by users who don't have full access to the plugin repository.

The following errors have appeared in the recent submitted PRs.

@john-dupuy
Copy link
Contributor

Hi @Samweli - thanks for the bug report.

Failing due to long running time, some tests matrix timeout at 3mins and 28/29 secs - https://github.com/planetlabs/qgis-planet-plugin/actions/runs/3375040820/jobs/5601295038#step:3:204

I believe this is because of the last issue "No access to planet credentials"

Missing py package, in some PRs running docker tests throws an exception about not finding the py module - https://github.com/planetlabs/qgis-planet-plugin/actions/runs/3376868140/jobs/5605108944#step:3:176

It looks like there was an update that broke the install step - investigating.

@john-dupuy
Copy link
Contributor

For the no access to planet credentials - pull requests on this repository must be submitted via a branch of the repo so that it has access to those credentials. Please let me know if you're able to submit pull requests in this way.

@john-dupuy
Copy link
Contributor

#65 addresses:

@Samweli
Copy link
Collaborator Author

Samweli commented Nov 8, 2022

#65 addresses:

Thanks @john-dupuy

This was referenced Nov 8, 2022
@Samweli
Copy link
Collaborator Author

Samweli commented Nov 8, 2022

Closed via #65

@Samweli Samweli closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants