Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for global categories, releases, fix bugged tests #893

Merged
merged 7 commits into from Nov 26, 2022

Conversation

kevinsekuj
Copy link
Contributor

@kevinsekuj kevinsekuj commented Nov 26, 2022

Additions

  • Added further unit tests for new releases, passing limit parameter with minimum and maximum values of 1 and 50
  • Added further unit tests for categories, omitting country code to test global releases

Fixes

  • Fixed potential error where found variable in test_artist_related_artists tests/integration/non_user_endpoints/test.py is undefined if for loop never evaluates to true
  • Fixed false positive test test_new_releases which looks up the wrong property of the JSON response object and always evaluates to true

@kevinsekuj
Copy link
Contributor Author

@stephanebruckert any ideas why the job for python build fails?

@stephanebruckert
Copy link
Member

@kevinsekuj I just fixed it on the default branch

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@stephanebruckert stephanebruckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanebruckert stephanebruckert merged commit 5201f58 into spotipy-dev:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants