Allow to set custom key in RedisCacheHandler #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanebruckert
approved these changes
Dec 22, 2021
|
Looks good, please just add a changelog |
|
I added the changes to the changelog and I also added another check before trying to retrieve the value to make sure that the key exists (already noticed by @Findus23 in #747 (review)) |
|
Thank you! |
|
Sorry, to nitpick once again, but isn't something like token_info = self.redis.get('token_info')
if token_info:
return json.loads(token_info)easier as it only does one request to redis instead of two (and doesn't have a really unlikely race-condition)? |
|
@Findus23 that's fair! |
IdmFoundInHim
pushed a commit
to IdmFoundInHim/spotipy
that referenced
this pull request
Dec 23, 2021
* Allow to set custom key in RedisCacheHandler * Update CHANGELOG.md * Check for the existence of the key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use a different key than the one that is always set, so I thought it might be a good idea to allow users of the
RedisCacheHandlerto supply their own key and only set it to the default value oftoken_infoif the key is not supplied as an argument.