Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

albums endpoint should have country/market param #753

Closed
jadenmazzone opened this issue Dec 9, 2021 · 7 comments
Closed

albums endpoint should have country/market param #753

jadenmazzone opened this issue Dec 9, 2021 · 7 comments

Comments

@jadenmazzone
Copy link

Very simple but the albums(albums) endpoint should be albums(albums, country). According to Spotify Get Several Albums.

@stephanebruckert
Copy link
Member

Can you please elaborate on:

According to Spotify Get Several Albums.

@jadenmazzone
Copy link
Author

Can you please elaborate on:

According to Spotify Get Several Albums.

This is the endpoint on spotify: https://developer.spotify.com/console/get-several-albums/. As you can see they have a "market" parameter. So I'm saying that this needs to be added to the "albums" endpoint.

@jadenmazzone
Copy link
Author

Just "album" is also missing a market/country param.

@stephanebruckert
Copy link
Member

stephanebruckert commented Dec 9, 2021

You probably refer to Spotify.albums or Spotify.album which both look for specific album(s) while the market parameter already exists on the album search method https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.artist_albums, see the country parameter

@jadenmazzone
Copy link
Author

Those are different endpoints...Artist_albums does not give any track information while spotify albums / album does, therefore have different responses / data. https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.albums and https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.album should have a "country" param.

@stephanebruckert
Copy link
Member

stephanebruckert commented Dec 9, 2021

stephanebruckert pushed a commit that referenced this issue Jun 18, 2022
…753 (#800)

* Updated references to ISO 639 standard to clarify that the ISO 639-1 alpha-2 standard is used.

* Added `market` parameter to `album` and `albums`

* fix formatting change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants