Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron version #54

Closed
AllanChain opened this issue Dec 25, 2020 · 5 comments
Closed

Electron version #54

AllanChain opened this issue Dec 25, 2020 · 5 comments

Comments

@AllanChain
Copy link
Member

AllanChain commented Dec 25, 2020

现在 master 上是把 electron pin 在 v11.0.0 (#51)

但是该版本有 bug,打开弹幕窗口的时候报错 screen.getAllDisplays is not a function (electron/electron/issues/26610)

升级到 v11.1.1 后,又出现本该透明的弹幕窗口却是黑色的问题,暂未找到对应 issue。(tested on win10)

但是经测试发现 v11.0.3 没有问题。

所以我觉得应该改 electron version 为一个合适的版本

@stevenjoezhang
Copy link
Member

谢谢,我会暂时将 electron 版本改为 v11.0.3。v11.1.1 出现的问题需要进一步测试。

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Dec 25, 2020

在 macOS 上没有复现窗口透明度问题,因此问题的来源可能是以下几处与 Windows 相关的改动
electron/electron#26754
electron/electron#26774
electron/electron#26780

另见 electron/electron#27286electron/electron#27265

@stevenjoezhang
Copy link
Member

我这样改了之后没问题了 6c39c18
你有兴趣的话可以帮忙测试一下

@AllanChain
Copy link
Member Author

测试过了,显示正常。不过窗口减几个像素的操作属实有点 tricky 😂

@stevenjoezhang
Copy link
Member

现在升级到了 Electron v16,这个问题似乎解决了(在 Windows 11 21H2 22000.376 上测试正常)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants