Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Plugin::init async #24

Open
Tracked by #40
pksunkara opened this issue Feb 23, 2021 · 0 comments
Open
Tracked by #40

Make Plugin::init async #24

pksunkara opened this issue Feb 23, 2021 · 0 comments
Labels
C: plugin Context: Plugin library D1: trivial Difficulty: Trivial to implement for beginners T: ergonomics Type: Ergonomic improvement U4: nice to have Urgency: Nice to have W: msrv Waiting: Needs MSRV bump

Comments

@pksunkara
Copy link
Owner

Needs rust async_traits. rust-lang/rfcs#2739

An example would be RedisPlugin currently doing build_unchecked because this fn is not async.
@pksunkara pksunkara added E: rust External: Rust U1: urgent Urgency: Urgent T: ergonomics Type: Ergonomic improvement D1: trivial Difficulty: Trivial to implement for beginners C: plugin Context: Plugin library W: external Waiting: External labels Feb 23, 2021
@pksunkara pksunkara changed the title Make plugin::init async Make Plugin::init async Feb 23, 2021
@pksunkara pksunkara added U3: want to have Urgency: Want to have U4: nice to have Urgency: Nice to have and removed U1: urgent Urgency: Urgent U3: want to have Urgency: Want to have labels Feb 23, 2021
@pksunkara pksunkara mentioned this issue Feb 3, 2022
Open
3 tasks
@pksunkara pksunkara added W: msrv Waiting: Needs MSRV bump and removed E: rust External: Rust W: external Waiting: External labels Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: plugin Context: Plugin library D1: trivial Difficulty: Trivial to implement for beginners T: ergonomics Type: Ergonomic improvement U4: nice to have Urgency: Nice to have W: msrv Waiting: Needs MSRV bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pksunkara