Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitCommitsCheck #2

Open
ezzieyguywuf opened this issue Feb 18, 2021 · 2 comments
Open

Add GitCommitsCheck #2

ezzieyguywuf opened this issue Feb 18, 2021 · 2 comments

Comments

@ezzieyguywuf
Copy link

The pkgcheck scan --commits --check GitCommitsCheck adds a check to ensure that commit messages are formatted properly - this works as a fair stand-in for repoman commit.

Is it possible to add this check for Pull Requests? It should be pretty straighforward, since --commits automatically checks against master.

This would be a bit more challenging to run on master - it'd be trivial to add --commits HEAD~, but what if more than one commit was just pushed?

@radhermit
Copy link
Contributor

This is more related to pkgcheck ci support (pkgcore/pkgcheck#282) or even the pkgcheck-action project instead since this repo is basically just for example CI configs.

@radhermit radhermit transferred this issue from another repository Feb 18, 2021
@ezzieyguywuf
Copy link
Author

This is more related to pkgcheck ci support (pkgcore/pkgcheck#282) or even the pkgcheck-action project instead since this repo is basically just for example CI configs.

Thanks for moving it, I was a bit confused about the different projects when I submitted the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants