Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: open_pty_master Ptsname grantpt unlockpt #27

Open
CodyGuo opened this issue Feb 5, 2018 · 9 comments
Open

undefined: open_pty_master Ptsname grantpt unlockpt #27

CodyGuo opened this issue Feb 5, 2018 · 9 comments

Comments

@CodyGuo
Copy link

CodyGuo commented Feb 5, 2018

github.com/pkg/term/termios

..............\pkg\term\termios\pty.go:20:14: undefined: open_pty_master
..............\pkg\term\termios\pty.go:25:16: undefined: Ptsname
..............\pkg\term\termios\pty.go:30:8: undefined: grantpt
..............\pkg\term\termios\pty.go:35:8: undefined: unlockpt

@davecheney
Copy link
Member

davecheney commented Feb 5, 2018 via email

@gdamore
Copy link
Contributor

gdamore commented Jun 25, 2019

This is seen when cross building for Solaris, or when building on Windows. I'll be following up with some fixes.

@CodyGuo
Copy link
Author

CodyGuo commented Jul 8, 2019

thanks

@xyproto
Copy link

xyproto commented Nov 23, 2020

I get these issues when building with GOOS=openbsd using go version go1.15.5 linux/amd64 on Arch Linux:

# github.com/pkg/term/termios
vendor/github.com/pkg/term/termios/pty.go:22:14: undefined: open_pty_master
vendor/github.com/pkg/term/termios/pty.go:27:16: undefined: Ptsname
vendor/github.com/pkg/term/termios/pty.go:32:8: undefined: grantpt
vendor/github.com/pkg/term/termios/pty.go:37:8: undefined: unlockpt

The results are the same for:

  • Latest master, d02e49d
  • An earlier commit that works with FreeBSD, but not with OpenBSD: c3ffed2

@davecheney
Copy link
Member

I tried to add some CI around this and from what I can tell, because the openbsd bindings use CGO it is difficult to cross compile them. I think this is the same problem that solaris faces.

@kylhuk
Copy link

kylhuk commented Dec 28, 2020

Experienced the same issue now. I transpiled a C file with c4go, which uses your package. Using Windows 10 (20H2) AMD64, Go 1.15.2, building with Goland 2020.3.

Attaching the go-file I'm trying to run.
main.zip

@davecheney
Copy link
Member

Thanks for the detail. I don’t know how to fix this as cross compiling cgo code is fraught with difficulty

@gdamore
Copy link
Contributor

gdamore commented Dec 28, 2020

Sorry I never followed up -- I think at some point I assumed @davecheney wasn't interested in contributions to this package, as of the two PRs I submitted to it, one took over a year to get merged (with no feedback in the interim) and the other is still outstanding (though it now had conflicts). I can try to resurrect my work (I wound up going a totally different to not depend on this package) if there is interest, but I don't want to invest the time to put together a fix if its just going to bitrot indefinitely.

@davecheney
Copy link
Member

@gdamore i sent you an invite to this repo so I won’t be a blocker any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants