Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal/exposeRemoveFile #555

Open
edugamo1993 opened this issue Aug 24, 2023 · 2 comments
Open

proposal/exposeRemoveFile #555

edugamo1993 opened this issue Aug 24, 2023 · 2 comments

Comments

@edugamo1993
Copy link

Some of our use cases require the Remove() function to return an EPERM error.
Like RemoveDirectory(), I think removeFile() should be exposed and keep Remove() for use when the developer doesn't know if the resource is a file or a directory.

I tried to create a branch and a Pull Request but I don't have permissions

@puellanivis
Copy link
Collaborator

This is already an open change and proposal. #548

@puellanivis puellanivis closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
@puellanivis puellanivis reopened this Aug 24, 2023
@puellanivis
Copy link
Collaborator

puellanivis commented Aug 24, 2023

I intended to close the PR, not this issue thread. Discussion about this topic can occur here perhaps better than the PR.

But I will quote my comment from there:

I’m kind of averse to this. We probably shouldn’t have exposed RemoveDirectory in the first place. As it seems it was exported as a least-change work-around for an issue people were seeing, but a more robust solution would have been to properly address the out-of-spec situation.

In the linked issue, I covered what the correct solution should be, I just haven’t had time to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants