[bug] PosixRename and Hardlink don’t convert remote paths to local paths #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Issue #491 it was noticed that the extended packet for PosixRename is not converting remote paths to local paths. During examination looking for the same issue, Hardlink was found to have the same issue. StatVFS is unnecessary to check, as Windows does not support it.
Included in addition, fixing up the integration test both client and server so that they function from within
WSLwhenGOOS=windows. For anyone developing through WSL, this means they can quickly test the Windows implementation, as well as the Linux one from the same command-line.