Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Reduce allocations in Stacktrace.Format #194

Merged
merged 1 commit into from Jan 9, 2019
Merged

Reduce allocations in Stacktrace.Format #194

merged 1 commit into from Jan 9, 2019

Conversation

davecheney
Copy link
Member

@davecheney davecheney commented Jan 9, 2019 •
edited

Updates #150

benchmark                                        old allocs     new allocs     delta  
BenchmarkErrors/pkg/errors-stack-10-8            3              3              +0.00% 
BenchmarkErrors/errors-stack-10-8                1              1              +0.00% 
BenchmarkErrors/pkg/errors-stack-100-8           3              3              +0.00% 
BenchmarkErrors/errors-stack-100-8               1              1              +0.00%
BenchmarkErrors/pkg/errors-stack-1000-8          3              3              +0.00%
BenchmarkErrors/errors-stack-1000-8              1              1              +0.00%
BenchmarkStackFormatting/%s-stack-10-8           1              1              +0.00%
BenchmarkStackFormatting/%v-stack-10-8           1              1              +0.00%
BenchmarkStackFormatting/%+v-stack-10-8          19             19             +0.00%
BenchmarkStackFormatting/%s-stack-30-8           1              1              +0.00%
BenchmarkStackFormatting/%v-stack-30-8           1              1              +0.00%
BenchmarkStackFormatting/%+v-stack-30-8          33             33             +0.00%
BenchmarkStackFormatting/%s-stack-60-8           1              1              +0.00%
BenchmarkStackFormatting/%v-stack-60-8           1              1              +0.00%
BenchmarkStackFormatting/%+v-stack-60-8          33             33             +0.00%
BenchmarkStackFormatting/%s-stacktrace-10-8      5              2              -60.00%
BenchmarkStackFormatting/%v-stacktrace-10-8      8              5              -37.50%
BenchmarkStackFormatting/%+v-stacktrace-10-8     7              5              -28.57%
BenchmarkStackFormatting/%s-stacktrace-30-8      5              2              -60.00%
BenchmarkStackFormatting/%v-stacktrace-30-8      5              2              -60.00%
BenchmarkStackFormatting/%+v-stacktrace-30-8     4              2              -50.00%
BenchmarkStackFormatting/%s-stacktrace-60-8      5              2              -60.00%
BenchmarkStackFormatting/%v-stacktrace-60-8      5              2              -60.00%
BenchmarkStackFormatting/%+v-stacktrace-60-8     4              2              -50.00%

Signed-off-by: Dave Cheney dave@cheney.net

@davecheney davecheney added this to the 0.9 milestone Jan 9, 2019
@davecheney davecheney changed the title Reduce allocations in {stack,StackTrace}.Format Reduce allocations in Stacktrace.Format Jan 9, 2019
@davecheney
Reduce allocations in StackTrace.Format
58be0d7 
Updates #150

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney merged commit ffb6e22 into master Jan 9, 2019
This was referenced Mar 15, 2021
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@davecheney