From d55dfb5abd41729f4de2012b0c62e82928f73ceb Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Tue, 17 Jan 2023 20:31:22 +0800 Subject: [PATCH 1/2] Fix: Workaround for transpilation failure --- .../src/textures/resources/ImageBitmapResource.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/core/src/textures/resources/ImageBitmapResource.ts b/packages/core/src/textures/resources/ImageBitmapResource.ts index ea09396412..78dadea5ef 100644 --- a/packages/core/src/textures/resources/ImageBitmapResource.ts +++ b/packages/core/src/textures/resources/ImageBitmapResource.ts @@ -59,18 +59,21 @@ export class ImageBitmapResource extends BaseImageResource { options = options || {}; + let baseSource; + let url; + if (typeof source === 'string') { - super(ImageBitmapResource.EMPTY); - - this.url = source; + baseSource = ImageBitmapResource.EMPTY; + url = source; } else { - super(source); - - this.url = null; + baseSource = source; + url = null; } + super(baseSource); + this.url = url; this.crossOrigin = options.crossOrigin ?? true; this.alphaMode = typeof options.alphaMode === 'number' ? options.alphaMode : null; From 96087af827cced677ad3c9be64ba40d8605313b5 Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 21 Jan 2023 01:36:26 +0800 Subject: [PATCH 2/2] Add comment --- packages/core/src/textures/resources/ImageBitmapResource.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/core/src/textures/resources/ImageBitmapResource.ts b/packages/core/src/textures/resources/ImageBitmapResource.ts index 78dadea5ef..aab555fd54 100644 --- a/packages/core/src/textures/resources/ImageBitmapResource.ts +++ b/packages/core/src/textures/resources/ImageBitmapResource.ts @@ -72,6 +72,8 @@ export class ImageBitmapResource extends BaseImageResource baseSource = source; url = null; } + // Using super() in if() can cause transpilation problems in some cases, so take it out of if(). + // See https://github.com/pixijs/pixijs/pull/9093 for details. super(baseSource); this.url = url;