Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the onProgress design limitations in docs #8962

Merged
merged 1 commit into from Dec 11, 2022
Merged

Clarify the onProgress design limitations in docs #8962

merged 1 commit into from Dec 11, 2022

Conversation

bigtimebuddy
Copy link
Member

Closes #8819

Make it explicit not to fetch assets in the onProgress callback.

@bigtimebuddy bigtimebuddy requested a review from a team December 9, 2022 20:17
travispulley
travispulley reviewed Dec 10, 2022
View reviewed changes
Copy link

@travispulley travispulley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear and descriptive. Seems like good information that would save someone a lot of time. I haven't used it directly to verify correctness, but it sounds plausible and I trust added detail over no detail.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 11, 2022
@bigtimebuddy bigtimebuddy merged commit a299f43 into dev Dec 11, 2022
@bigtimebuddy bigtimebuddy deleted the fix/onprogress-docs branch December 11, 2022 15:22
bigtimebuddy added a commit that referenced this pull request Dec 12, 2022
@bigtimebuddy
Clarify the onProgress limitations in documentation (#8962)
e1ea3a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travispulley travispulley travispulley left review comments

@SuperSodaSea SuperSodaSea SuperSodaSea approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assets progress callback reports 1 before finished loading assets
3 participants
@bigtimebuddy @travispulley @SuperSodaSea