Chore: Cleanup core dependencies #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the import fixes to core are good 👍 I'm not into the import order changes. These are an "unstable style changes"-- someone can easily change it later not knowing what the rule is. The best solution here is to add an eslint rule that enforces some standard. I think this should be another PR. |
SuperSodaSea
force-pushed
the
chore/cleanup-core-dependencies
branch
from
6eb296c
to
b46a169
Compare
|
@bigtimebuddy Okay, it is reverted. |
bigtimebuddy
added
the
✅ Ready To Merge
bigtimebuddy
pushed a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Follow up #8619.
Change some imports from
@pixi/math,@pixi/settings,@pixi/utilsto@pixi/core, mainly someICanvasstuff.Also some import sorting is included.Pre-Merge Checklist
npm run lint)npm run test)