Support loading font assets in data URLs #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Can you add a test for loading a font from data-uri? |
|
Let me see if I can find a small font file for test... |
|
icomoon.io is a good place to make a font with a single glyph |
|
Test added! |
bigtimebuddy
approved these changes
Nov 27, 2022
bigtimebuddy
added
the
✅ Ready To Merge
|
Nice work! |
|
@SuperSodaSea thank u so much!!! Nice work 👍 |
bigtimebuddy
pushed a commit
that referenced
this pull request
Dec 12, 2022
|
Is there any documentation for this? I'm unable to get this working. No errors, just a weird asset cached and Pixi.Text uses the standard serif font when rendering my text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading font assets in data URLs.
Closes #8891.
Description of Change
loadWebFontnow support data URLsfont/ttf,font/otf,font/woff,font/woff2packages/assets/src/loader/parsers/textures/utils/index.tsis moved topackages/assets/src/utils/checkExtension.tspackages/assets/src/utils/checkDataUrl.tsis added to check if a URL is a data URL with the given MIME typesimage/jpgis no longer considered as a valid MIME type forloadTextures(onlyimage/jpegshould be valid)Pre-Merge Checklist
npm run lint)npm run test)