Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cleanup useContextAlpha deprecation #8866

Merged
merged 3 commits into from Nov 21, 2022
Merged

Conversation

bigtimebuddy
Copy link
Member

Closes #8861

Changed

  • Removes useContextAlpha from the Application, CanvasRenderer and Renderer options documentation
  • Add deprecation flag to useContextAlpha in IRenderOptions
  • Always set a default for premultipliedAlpha as this is now a required field
  • Add deprecation warnings and fallback behavior for useContextAlpha with constructor arguments

@bigtimebuddy bigtimebuddy requested a review from a team November 19, 2022 15:24
Copy link
Member

@SuperSodaSea SuperSodaSea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, the deprecation message seems to be incorrect here:

/**
* This sets weather the screen is totally cleared between each frame withthe background color and alpha
* @deprecated since 7.0.0
*/
get clearBeforeRender(): boolean
{
// #if _DEBUG
// eslint-disable-next-line max-len
deprecation('7.0.0', 'renderer.useContextAlpha has been deprecated, please use renderer.background.clearBeforeRender instead.');
// #endif
return this.background.clearBeforeRender;
}

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 21, 2022
@bigtimebuddy bigtimebuddy merged commit f791f7c into dev Nov 21, 2022
@bigtimebuddy bigtimebuddy deleted the chore/use-context-alpha branch November 21, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useContextAlpha not marked as deprecated in docs
3 participants