Fix: Jest running on Windows #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
added
the
✅ Ready To Merge
SuperSodaSea
changed the title
bigtimebuddy
pushed a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously using
npm teston Windows will reportError: spawn http-server ENOENTdue to the difference on the shell between Windows and other Unix-like OS. Since I usually working on Windows, I modified the Jest setup & teardown script to make it working on Windows. Packagetree-killis introduced to properly kill thehttp-serveron Windows, sinceprocess.kill()will only kill the shell but not the realhttp-serverprocess.See https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows for more details.
Pre-Merge Checklist
npm run lint)npm run test)