Fix loseContext/restoreContext #8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
approved these changes
Nov 10, 2022
bigtimebuddy
added
the
✅ Ready To Merge
|
Should this PR link to #7232? |
bigtimebuddy
added a commit
that referenced
this pull request
Dec 12, 2022
Co-authored-by: Matt Karl <matt@mattkarl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes context restoration after a loss. It didn't seem to work before. I think this is the correct way to restore the context.
Test: Lose context after 1 sec.
Systems need to call
disposeAll(true)before assigning the newCONTEXT_UIDincontextChange. The framebuffer system was calling it after.Pre-Merge Checklist
npm run lint)npm run test)