Re-enable eslint import plugin

[twschiller]

Context:

• Cleanup eslint config #562 (comment)
• [no-unused-modules] The "path" argument must be of type string. Received undefined import-js/eslint-plugin-import#1931

"plugin:import/errors",   
"plugin:import/warnings",

[fregante]

I can fix this by the way. Eslint does not need the fs: false part in webpack’s config, so I can exclude it from the import:

• quick fix: just delete the property after import
• good fix: further clean/deduplicate config

[twschiller]

Would be good to fix, especially as we'll want to use to help with modules with broken tree-shaking. I'd err on the side of the quick fix, but not sure I understand the alternatives

exclude it from the import

Which import?

further clean/deduplicate config

I'm not sure I follow - what would this involve?

[fregante]

exclude it from the import

Which import?

I thought we were requireing the webpack file so I thought we could process it first, but instead we just pass a file path to it:

pixiebrix-extension/.eslintrc

Line 14 in b588518

"config": "./browsers/webpack.config.js"

Maybe the quick fix isn't that quick. Maybe ESLint can be detected from process.env inside webpack.config.js instead?

further clean/deduplicate config

I'm not sure I follow - what would this involve?

I haven't looked into the details, but the aliases are defined in 2/3 files (including Jest’s config) so we should merge those while also exporting a eslint-compatible webpack configuration that solves this issue. How exactly I don't know yet.

[fregante]

To be clear, this is the problematic object, sorry for being vague:

pixiebrix-extension/browsers/webpack.config.js

Lines 232 to 238 in b588518

	fallback: {
	fs: false,
	crypto: false,
	console: false,
	vm: false,
	path: false,
	},

ESLint doesn't need this so we can just somehow exclude this specific part from webpack’s config when ESLint imports the file.