-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast query parameters as string #13
base: master
Are you sure you want to change the base?
Conversation
can we get it merged? |
Sorry for such a long time waiting for a reply. PR has quite big diff - at first glance it looks fine - but i'll try to make CR asap. |
Maybe I can rework this PR to only fix original error and move feature about logger into another one (which may be dependent on this one) |
…so require at least version 1.38 of Twig to make sure PSR-4 namespaced classes are added
…orkBundle\Templating\EngineInterface" is deprecated
… "Doctrine\DBAL\Connection""
@ojrzenski I think it's fixed now. I've tested on 2.8 and 3.4. However, I might have failed my last push because it includes Twig updates (that's not my work) |
I can still reproduce it with symfony 3.4 and latest release of bundle |
When can this PR get merged? Still have the issue on Symfony 4.3 |
Fix #12
This also add information about connection's name in case of multiple entity managers
Queries are also sorted by execution order, regardless the connection
@ojrzenski For what I've tested, this works on my main project with Symfony 2.8 but I can't test it on newer versions (by now)