Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast query parameters as string #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jon-ht
Copy link
Contributor

@jon-ht jon-ht commented Jun 12, 2019

Fix #12

This also add information about connection's name in case of multiple entity managers

image

Queries are also sorted by execution order, regardless the connection

@ojrzenski For what I've tested, this works on my main project with Symfony 2.8 but I can't test it on newer versions (by now)

@ahilles107
Copy link
Contributor

can we get it merged?

@ojrzenski
Copy link
Contributor

Sorry for such a long time waiting for a reply.
I've tested this PR on symfony 3.4.x and 4.x.
At kernel compile i get error:
Attempted to call an undefined method named "setLogger" of class "Doctrine\DBAL\Connection"

PR has quite big diff - at first glance it looks fine - but i'll try to make CR asap.

@jon-ht
Copy link
Contributor Author

jon-ht commented Sep 21, 2019

Maybe I can rework this PR to only fix original error and move feature about logger into another one (which may be dependent on this one)

PabloKowalczyk and others added 3 commits October 26, 2019 02:05
…so require at least version 1.38 of Twig to make sure PSR-4 namespaced classes are added
…orkBundle\Templating\EngineInterface" is deprecated
@jon-ht
Copy link
Contributor Author

jon-ht commented Oct 26, 2019

@ojrzenski I think it's fixed now. I've tested on 2.8 and 3.4.

However, I might have failed my last push because it includes Twig updates (that's not my work)

@ahilles107
Copy link
Contributor

I can still reproduce it with symfony 3.4 and latest release of bundle

@danielgelling
Copy link

When can this PR get merged? Still have the issue on Symfony 4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object of class DateTime could not be converted to string
5 participants