Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#73 Force to disable junit5 parallel mode as PIT is not compatible wi… #74

Merged
merged 1 commit into from Jan 3, 2023

Conversation

tyge68
Copy link
Contributor

@tyge68 tyge68 commented Dec 18, 2022

…th it

@hcoles
Copy link
Contributor

hcoles commented Dec 20, 2022

@tyge68 thanks for this.

It sounds like we definitely want to disable parallel mode. Setting the system property directly feels a bit hacky though. I think it should be possible to implement this as an implementation of ConfigurationUpdater. This could add the property to the jvm args of the child processes in the same manner as the existing mac os focus one does in the main pitest repo.

https://github.com/hcoles/pitest/blob/master/pitest-entry/src/main/java/org/pitest/mutationtest/autoconfig/KeepMacOsFocus.java

This has the advantage that the auto adding could be turned off if ever required.

Would you be up for trying this in a pull request? The implementation and tests for the mac os focus updater should provide a good guide (one gotcha being to ensure you create a org.pitest.mutationtest.config.ConfigurationUpdater file in the META-INF/services)

@hcoles
Copy link
Contributor

hcoles commented Jan 3, 2023

@tyge68 Having taken another quick look at this, it's not clear that setting this via the config would override the other mechanisms by which it can be set, so merging as is.

Thanks.

@hcoles hcoles merged commit acb6406 into pitest:master Jan 3, 2023
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 12, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 13, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 15, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 15, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 19, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 19, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request May 19, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request Jun 9, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Vampire added a commit to Vampire/pitest-junit5-plugin that referenced this pull request Jun 23, 2023
This generically fixes hcoles/pitest#760 and pitest#73 for all platform engines,
removing the Jupiter specific work-around from pitest#74 and serializing test execution
during coverage calculation using locks. This way the tests can also properly run
in parallel later on during mutant hunting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants