protocol: fixed deadline datarace #86

[mschneider82]

Fixed the race by using atomic.Value instead of unprotected time.Time

It was nessasarry to restructure the Conn struct because of this:

struct of size 80 could be 72 (fieldalignment)

[coveralls]

Coverage increased (+0.02%) to 95.563% when pulling b4887c1 on mschneider82:master into 2e44d7a on pires:main.

[pires]

Thanks @mschneider82! Could you please turn on race mode for testing to prove this works (as it looks it does)?

[pires]

TIL https://medium.com/@sebassegros/golang-dealing-with-maligned-structs-9b77bacf4b97

[mschneider82]

I have added a nil check for atomic.Value with default time.Time{} (no deadline timeout) because TestPassthrough failed. In case no deadline was set

[mschneider82]

@pires i have tested it local with -race on. i will add -race to github actions

[mschneider82]

done, ready for review & merge

[pires]

Thanks a lot, @mschneider82!