Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix staticcheck warning: don't use Yoda conditions (ST1017) #82

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

drakkan
Copy link
Contributor

@drakkan drakkan commented Sep 6, 2021

No description provided.

@drakkan
Copy link
Contributor Author

drakkan commented Sep 8, 2021

These changes were included in the latest version of #80, closing

@drakkan drakkan closed this Sep 8, 2021
@pires pires reopened this Sep 8, 2021
@pires
Copy link
Owner

pires commented Sep 8, 2021

I'd prefer to keep this open and have it merged as part of your PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.353% when pulling b809180 on drakkan:staticcheck into 3aa7ea9 on pires:main.

@pires pires merged commit a55009f into pires:main Sep 8, 2021
@pires
Copy link
Owner

pires commented Sep 8, 2021

Thank you for your contribution. If you feel like helping a bit more, #73 is a blocker for us to move to Go 1.16+ 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants