diff --git a/.eslintrc.json b/.eslintrc.json index 02c79de..93bf977 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -27,6 +27,7 @@ "@typescript-eslint/no-empty-interface": "error", "@typescript-eslint/no-explicit-any": "error", "@typescript-eslint/no-extraneous-class": "error", + "@typescript-eslint/no-floating-promises": "error", "@typescript-eslint/no-for-in-array": "error", "@typescript-eslint/no-inferrable-types": "error", "@typescript-eslint/no-misused-new": "error", diff --git a/action.yml b/action.yml index 91d3982..4938ef0 100644 --- a/action.yml +++ b/action.yml @@ -1,4 +1,4 @@ -name: 'Checkout' +name: 'PipelineCheckout' description: 'Checkout a Git repository at a particular version' inputs: repository: diff --git a/dist/index.js b/dist/index.js index 9683c11..e765cc2 100644 --- a/dist/index.js +++ b/dist/index.js @@ -5498,7 +5498,7 @@ class GitAuthHelper { const configPaths = output.match(/(?<=(^|\n)file:)[^\t]+(?=\tremote\.origin\.url)/g) || []; for (const configPath of configPaths) { core.debug(`Replacing token placeholder in '${configPath}'`); - this.replaceTokenPlaceholder(configPath); + yield this.replaceTokenPlaceholder(configPath); } if (this.settings.sshKey) { // Configure core.sshCommand @@ -9594,7 +9594,7 @@ function downloadRepository(authToken, owner, repo, ref, commit, repositoryPath) else { yield toolCache.extractTar(archivePath, extractPath); } - io.rmRF(archivePath); + yield io.rmRF(archivePath); // Determine the path of the repository content. The archive contains // a top-level folder and the repository content is inside. const archiveFileNames = yield fs.promises.readdir(extractPath); @@ -9613,7 +9613,7 @@ function downloadRepository(authToken, owner, repo, ref, commit, repositoryPath) yield io.mv(sourcePath, targetPath); } } - io.rmRF(extractPath); + yield io.rmRF(extractPath); }); } exports.downloadRepository = downloadRepository; diff --git a/src/git-auth-helper.ts b/src/git-auth-helper.ts index fc1404c..291d83b 100644 --- a/src/git-auth-helper.ts +++ b/src/git-auth-helper.ts @@ -148,7 +148,7 @@ class GitAuthHelper { output.match(/(?<=(^|\n)file:)[^\t]+(?=\tremote\.origin\.url)/g) || [] for (const configPath of configPaths) { core.debug(`Replacing token placeholder in '${configPath}'`) - this.replaceTokenPlaceholder(configPath) + await this.replaceTokenPlaceholder(configPath) } if (this.settings.sshKey) { diff --git a/src/github-api-helper.ts b/src/github-api-helper.ts index 8bbcf2d..cadd13b 100644 --- a/src/github-api-helper.ts +++ b/src/github-api-helper.ts @@ -47,7 +47,7 @@ export async function downloadRepository( } else { await toolCache.extractTar(archivePath, extractPath) } - io.rmRF(archivePath) + await io.rmRF(archivePath) // Determine the path of the repository content. The archive contains // a top-level folder and the repository content is inside. @@ -70,7 +70,7 @@ export async function downloadRepository( await io.mv(sourcePath, targetPath) } } - io.rmRF(extractPath) + await io.rmRF(extractPath) } /**