Update promql for deployment count by project on overview controlplane dashboard #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dashboard Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
t-kikuc
approved these changes
May 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
- Coverage 29.32% 29.30% -0.02%
==========================================
Files 321 321
Lines 40835 40835
==========================================
- Hits 11974 11968 -6
- Misses 27904 27910 +6
Partials 957 957 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Group the deployment counter based on "project" label, previously without
sum bythe project counters are showing separately because of theinstancelabel diff ofgrpcapi_create_deployment_totalmetric.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: