-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Skip stages when the commit is not important (Analysis,WaitApproval,Wait,ScriptRun) #4899
Comments
[Acknowledgment] |
I would like to add |
thanks, I agree with you and it's easily possible. |
cf. Skipping the |
The In our case, we plan to trigger an e2e testing by a script run stage. The stage should be skipped for quick rollback. |
I'll take this PR |
What would you like to be added
A new feature of skipping the
ANALYSIS
orWAIT_APPROVAL
stages when the commit diff is not important.The configurable conditions of skipping the stage:
Why is it needed
Some users would like to skip the
ANALYSIS
orWAIT_APPROVAL
stages for faster and automatic deployment when the commit diff does not deserve analysis or approval.use cases:
(a) When you modify only the
HorizontalPodAutoscaler
of K8s resources in your config repo, skip theWAIT_APPROVAL
stage.(b) When you modify only
go.mod
dependencies in your source repo(not pipecd's config repo), skip theANALYSIS
stage.(c) Skip the
WAIT_APPROVAL
stage when the change in your source repo is small, but skip both theWAIT_APPROVAL
andANALYSIS
stages when the change is tiny.How to realize it
skip
configuration to app.pipecd.yaml.Example1. How to realize the use case (b)
eventWatcher
andpipeline
in your app.pipecd.yaml.skip-analysis
if onlygo.mod
is changed.Example2. How to realize the use case (c)
eventWatcher
andpipeline
in your app.pipecd.yaml.small-change
to skip onlyWAIT_APPROVAL
, andtiny-change
to skip bothWAIT_APPROVAL
andANALYSIS
.Possible Extensions
commitMessagePrefixes
, it would be better to have other options like:skip.commitMessageOrBodyContains: []string
skip.commitMessageOrBodyContainsCommand: bool
[skip analysis]
,[skip stage]
, etc.The text was updated successfully, but these errors were encountered: