Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddICECandidate might not verify ufrag #2511

Open
jech opened this issue Jul 11, 2023 · 0 comments
Open

AddICECandidate might not verify ufrag #2511

jech opened this issue Jul 11, 2023 · 0 comments

Comments

@jech
Copy link
Contributor

jech commented Jul 11, 2023

Quoting https://w3c.github.io/webrtc-pc/#dom-peerconnection-addicecandidate:

  1. If candidate.usernameFragment is not null, and is not equal to any username fragment present in the corresponding media description of an applied remote description, return a promise rejected with a newly created OperationError.

However, I cannot find the place in the Pion code where we check that that ufrag matches the SDP, so I suspect that we're wrongly accepting candidates from the wrong generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants