Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reading github.com/pion/mediadevices/go.mod at revision v0.0.0: unknown revision v0.0.0 #441

Open
ZeoWorks opened this issue Sep 3, 2022 · 4 comments

Comments

@ZeoWorks
Copy link

ZeoWorks commented Sep 3, 2022

Hi, upon requesting signal;
go get github.com/pion/mediadevices/examples/internal/signal

This error occurs;
go: github.com/pion/mediadevices/examples@v0.0.0-20220824115655-3bec69bbf884 requires github.com/pion/mediadevices@v0.0.0: reading github.com/pion/mediadevices/go.mod at revision v0.0.0: unknown revision v0.0.0

No issue with any of the others. :)

@at-wat
Copy link
Member

at-wat commented Sep 4, 2022

Hi, thanks for trying out the package!
Subpackages under ./examples aren't designed to be used from other packages or product apps.
(Path including ./internal means unexported: https://go.dev/doc/go1.4#internalpackages)

If building any product apps, we recommend to implement proper and secure way to exchange SDPs.
If just trying the package, please copy the files under your package.

BTW, the direct reason of the error is due to replace:

replace github.com/pion/mediadevices v0.0.0 => ../

This is for separating deps only for examples from the main library and keep the examples buildable with the latest library.

@ZeoWorks
Copy link
Author

ZeoWorks commented Sep 7, 2022

Thank you, but this occurs even within your examples.
An example would be trying to build your webrtc sample;
https://github.com/pion/mediadevices/tree/master/examples/webrtc

@at-wat
Copy link
Member

at-wat commented Sep 7, 2022

@ZeoWorks Hmm, I couldn't reproduce the error on building ./examples/webrtc on Go 1.19 on Linux.
What environment, Go version, and pion/mediadevices version do you use?
Also, could you share the exact command and error log?

@ZeoWorks
Copy link
Author

Hi, go.1.19 on Windows, latest mediadevices version.
Thanks sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants