Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetReadDeadline #158

Merged
merged 1 commit into from Dec 12, 2022
Merged

Add SetReadDeadline #158

merged 1 commit into from Dec 12, 2022

Conversation

ckousik
Copy link
Contributor

@ckousik ckousik commented Dec 6, 2022

Description

Updates the underlying pion/sctp library and adds support in the datachannel Reader interface for calling the stream's SetReadDeadline method. A release will also have to be made in pion/sctp.

Reference issue

Fixes #...
#157

Updates the underlying pion/sctp library and adds support
in the datachannel Reader interface for calling the stream's
`SetReadDeadline` method.
@p-shahi
Copy link

p-shahi commented Dec 11, 2022

@Sean-Der @edaniels would either of you be able to review this PR. Thanks in advance 🙏

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 67.97% // Head: 68.18% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (e3b3db0) compared to base (1a83011).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   67.97%   68.18%   +0.20%     
==========================================
  Files           4        4              
  Lines         306      308       +2     
==========================================
+ Hits          208      210       +2     
  Misses         72       72              
  Partials       26       26              
Flag Coverage Δ
go 68.18% <100.00%> (+0.20%) ⬆️
wasm 68.18% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
message_channel_open.go 82.85% <ø> (ø)
datachannel.go 70.74% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@edaniels edaniels merged commit 6d03d00 into pion:master Dec 12, 2022
@ckousik
Copy link
Contributor Author

ckousik commented Dec 12, 2022

@edaniels When will new releases be made to pion/sctp, pion/datachannel, and subsequently, pion/webrtc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants