Fix loading custom rule sets #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y be fully initialized once PicoCli has parsed the arguments (see class Main). As of that, such variables can not be declared as class variables. Added as CLI Test to verify that a custom rule set based on RuleSetProviderV2 is actually loaded. * Add an '.editorconfig' override for each custom rule set that is loaded via a rule set JAR. * Fix sorting of Rule Runners. A rule can only be unblocked, if all run after rules which refer to a rule which is actually loaded, are added to the list of rules. The 'removeRunAfterRules' in the RuleRunner now actually modifies the list of RunAfterRules which have to be respected. * Allow urls in the About information to contain up to 120 characters and print stacktrace in case a rule set JAR can not be loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inline variables based on PicoCli Options. PicoCli Options will only be fully initialized once PicoCli has parsed the arguments (see class Main). As of that, such variables can not be declared as class variables. Added as CLI Test to verify that a custom rule set based on RuleSetProviderV2 is actually loaded.
Add an '.editorconfig' override for each custom rule set that is loaded via a rule set JAR.
Fix sorting of Rule Runners. A rule can only be unblocked, if all run after rules which refer to a rule which is actually loaded, are added to the list of rules. The 'removeRunAfterRules' in the RuleRunner now actually modifies the list of RunAfterRules which have to be respected.
Allow urls in the About information to contain up to 120 characters and print stacktrace in case a rule set JAR can not be loaded.
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule: