Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugs and cleanups #1724

Merged
merged 17 commits into from Dec 14, 2022
Merged

Conversation

paul-dingemans
Copy link
Collaborator

Description

Fix a number of small bugs (#1456) and last cleanup before release.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

…le annotation and has a redundant whiteline in between
…values in the '.editorconfig' file

The default EnumValueParser of ec4j does not ignore such spaces which incorrectly leads to values not parsed correctly. Additional trailing space typically result from EOL comments in the '.editorconfig' file. For example:
`codestyle = official # some comment`.
The comment (including the hash sign) is ignored correctly but the space which separates the value and the hash sign is added to the value itself.
…an be run (but only when enabled in the '.editorconfig' or when the "--experimental" flag is used in the CLI)
@paul-dingemans paul-dingemans added this to the 0.48.0 milestone Dec 14, 2022
@paul-dingemans paul-dingemans merged commit 6d5355a into pinterest:master Dec 14, 2022
@paul-dingemans paul-dingemans deleted the 1456-small-bugs branch December 14, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant