New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small bugs and cleanups #1724
Merged
paul-dingemans
merged 17 commits into
pinterest:master
from
paul-dingemans:1456-small-bugs
Dec 14, 2022
Merged
Small bugs and cleanups #1724
paul-dingemans
merged 17 commits into
pinterest:master
from
paul-dingemans:1456-small-bugs
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le annotation and has a redundant whiteline in between
…owed by whitespace
…values in the '.editorconfig' file The default EnumValueParser of ec4j does not ignore such spaces which incorrectly leads to values not parsed correctly. Additional trailing space typically result from EOL comments in the '.editorconfig' file. For example: `codestyle = official # some comment`. The comment (including the hash sign) is ignored correctly but the space which separates the value and the hash sign is added to the value itself.
…an be run (but only when enabled in the '.editorconfig' or when the "--experimental" flag is used in the CLI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a number of small bugs (#1456) and last cleanup before release.
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule: